Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add older version(s) of rocksdb #77

Closed
wants to merge 1 commit into from

Conversation

tedil
Copy link

@tedil tedil commented Oct 18, 2024

As far as I know, rocksdb occasionally has API changes between minor versions.
Since I use rust bindings to rocksdb (i.e. rust-rocksdb) in multiple projects for which I want to build conda packages, and since building rocksdb from scratch in the (bioconda) CI usually times out / exceeds resource usage, I'd like to link against pre-built rocksdb instead. For that to work, however, the versions of rocksdb and rust-rocksdb need to be compatible.

The newest 8.x release of rocksdb available from conda-forge is 8.5.3; whereas rust-rocksdb is currently okay with >=8.9.1.
I'd therefore be happy to somehow get a build of rocksdb 8.9.1 (or 8.10.x).

This PR should not be merged to main, but rather to a separate, yet-to-be-created branch ("8.x", I guess).

P.S.: I had to introduce a change to be able to submit a draft PR, which is basically an exit 1 in the build script to avoid accidentally processing/merging/triggering stuff.

See also bioconda/bioconda-recipes#51210

cc @mbargull

@conda-forge-admin
Copy link
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe/meta.yaml) and found it was in an excellent condition.

@jeongseok-meta jeongseok-meta mentioned this pull request Nov 10, 2024
5 tasks
@jeongseok-meta
Copy link
Contributor

jeongseok-meta commented Nov 11, 2024

Hi @tedil, would 8.11.4 work for you? It seems the latest major version 8. https://github.com/facebook/rocksdb/tags?after=v9.1.1

@tedil
Copy link
Author

tedil commented Nov 11, 2024

Hi @tedil, would 8.11.4 work for you? It seems the latest major version 8. https://github.com/facebook/rocksdb/tags?after=v9.1.1

I suppose so, though the latest mentioned rocksdb version for rust-rocksdb is 8.10.0, see https://github.com/rust-rocksdb/rust-rocksdb/releases/tag/v0.22.0
(Also, ubuntu noble ships 8.9.1, for which at least I can confirm that the rust-rocksdb bindings work ^^)

@jeongseok-meta
Copy link
Contributor

Good to know. Let's add the 8.10.x branch for now and consider upgrading or replacing it with 8.11.x if necessary in the future.

@jeongseok-meta
Copy link
Contributor

It seems a354eab could be a good base commit.

@jeongseok-meta
Copy link
Contributor

#87
#88

@jeongseok-meta
Copy link
Contributor

Closing as it should be resolved by #87 and #88!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants